[libcamera-devel] [PATCH v2 15/17] v4l2: v4l2_camera_proxy: Don't allow streamon if no buffers have been requested

Paul Elder paul.elder at ideasonboard.com
Fri Jun 19 07:41:21 CEST 2020


Make VIDIOC_STREAMON return -EINVAL if no buffers have been allocated
with reqbufs.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

---
New in v2
- split from "Fix v4l2-compliance streaming tests"
---
 src/v4l2/v4l2_camera_proxy.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index 8396f58..a7f987a 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -637,6 +637,9 @@ int V4L2CameraProxy::vidioc_streamon(V4L2CameraFile *cf, int *arg)
 {
 	LOG(V4L2Compat, Debug) << "Servicing vidioc_streamon fd = " << cf->efd();
 
+	if (bufferCount_ == 0)
+		return -EINVAL;
+
 	if (vcam_->isRunning())
 		return 0;
 
-- 
2.27.0



More information about the libcamera-devel mailing list