[libcamera-devel] [PATCH 1/3] libcamera: add a sharpness strength control
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Jun 22 04:07:15 CEST 2020
Hi David,
Thank you for the patch.
On Fri, Jun 19, 2020 at 10:27:23AM +0100, David Plowman wrote:
> The control is a single float value with minimum, default and maximum
> values. Please read the description for more details.
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
> src/libcamera/control_ids.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 77ebc3f..1bc1b10 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -239,4 +239,15 @@ controls:
> pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels
> control can only be returned in metadata.
> size: [4]
> +
> + - Sharpness:
> + type: float
> + description: |
> + The strength of the sharpening to be applied.
Should we specify that sharpening is not applied to RAW streams ? Or do
you expect hardware that would be able to apply sharpening in the Bayer
domain ?
> The minimum value
> + means minimal (or preferably no) sharpening, the maximum should
> + signify extremely high levels of sharpening (higher than anyone could
> + reasonably want), and the default value should give a "reasonable"
> + level, suitable for many use cases. We recommand that the amount
> + of sharpening applied should be "approximately" proportional to this
> + parameter.
I propose detailing this a bit further, to explain that 0 means no
sharpening. How about the following ?
A value of 0.0 means no sharpening. The minimum value means
minimal sharpening, and shall be 0.0 unless the camera can't
disable sharpening completely. The default value shall give a
"reasonable" level or sharpening, suitable for most use cases.
The maximum value may apply extremely high levels of sharpening,
higher than anyone could reasonably want. Negative values are
not allowed.
> ...
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list