[libcamera-devel] [PATCH] Correct small typo in method description

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Jun 23 12:44:42 CEST 2020


Hi Chris,

On 23/06/2020 11:41, Kieran Bingham wrote:
> Hi Chris,
> 
> On 23/06/2020 11:37, chris at gregariousmammal.com wrote:
>> From: Chris Chinchilla <chris at gregariousmammal.com>
>>
>> Correct small typo in method description
> 
> Missing a new line between the commit message and the trailing tags
> section. I'll add it while applying.
> 
> 
>> Fixes: d6a88607479 ("libcamera: pipeline_handler: Keep track of MediaDevice")
>> Signed-off-by: Chris Chinchilla <chris at gregariousmammal.com>

Ahh, this should also be your 'real name'.

I suspect there's a personal preference in using the Chinchilla ... but
the 'Signed-off-by' tags are sort of a legal-declaration for licencing
purposes.

--
Kieran

> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> Thanks.
> 
> 
>> ---
>>  src/libcamera/pipeline_handler.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
>> index 14dfba0..2eb86ad 100644
>> --- a/src/libcamera/pipeline_handler.cpp
>> +++ b/src/libcamera/pipeline_handler.cpp
>> @@ -181,7 +181,7 @@ PipelineHandler::~PipelineHandler()
>>   */
>>  
>>  /**
>> - * \brief Search and acquire a MediDevice matching a device pattern
>> + * \brief Search and acquire a MediaDevice matching a device pattern
>>   * \param[in] enumerator Enumerator containing all media devices in the system
>>   * \param[in] dm Device match pattern
>>   *
>>
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list