[libcamera-devel] [PATCH] Fix incorrect method in cameradata docs

Umang Jain email at uajain.com
Tue Jun 23 19:38:07 CEST 2020


Hi Chris,

Did you re-send this patch by mistake? It's identical with the patch
you sent on 6/15/2020.

When you re-send the patch, you need to also mention that the patch is
the second (or third, fourth ...) iteration of the initial patch.
You can do that by adding "-v2" to "git format-patch ..." commandline
to denote that it's the second version of that patch.

Also, since you got Reviewed-by tags by me and Laurent, you need to collect
them too and add it to your commit message while re-sending them for the
second round of review.

On 6/23/20 4:27 PM, chris at gregariousmammal.com wrote:
> From: Chris Chinchilla <chris at gregariousmammal.com>
>
> Fix incorrect method in cameradata docs
>
> Fixes: b581b9576abd ("libcamera: pipeline_handler: Make pipeline-specific data mandatory")
> Signed-off-by: Chris Chinchilla <chris at gregariousmammal.com>
> ---
>   src/libcamera/pipeline_handler.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index 14dfba0..15cdc17 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)
>    *
>    * Pipeline handlers are expected to extend this base class with platform
>    * specific implementation, associate instances of the derived classes
> - * using the setCameraData() method, and access them at a later time
> + * using the registerCamera() method, and access them at a later time
>    * with cameraData().
>    */
>   


More information about the libcamera-devel mailing list