[libcamera-devel] [PATCH 1/4] libcamera: controls: Add focus Figure of Merit (FoM) control

[David Plowman]

Hi Naush

Thanks for this. Just the one nit-picky little typo (sorry!),
otherwise looks good to me!

Best regards
David

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>


On Fri, 26 Jun 2020 at 11:25, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> Provide a control to allow the IPA to return a FoM to indicate how
> in-focus a scene is. Note, this is not to be used as a means to
> implement a focus algorithm by the application, rather an indication of
> how in-focus a scene is.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/libcamera/control_ids.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 8c3e4c72..b46693ec 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -251,4 +251,15 @@ controls:
>          higher than anyone could reasonably want. Negative values are
>          not allowed. Note also that sharpening is not applied to raw
>          streams.
> +
> +  - FocusFoM:
> +      type: int32_t
> +      description: |
> +        Reports a Figure of Merit (FoM) to indicate how in-focus the frame is.
> +        A larger FocusFoM value indicates a more in-focus frame. This control
> +        depends on the IPA to gather ISP statistics from the defined focus
> +        region, and combine them in a suitable way to generate a FocusFoM value.
> +        In this respect, it is not necessarily aimed a providing a way to

"aimed at providing"

> +        implement a focus algorithm by the application, rather an indication of
> +        how in-focus a frame is.
>  ...
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel