[libcamera-devel] [PATCH 2/4] libcamera: ipa: raspberrypi: focus: Fix for uninitialised variable

[David Plowman]

Hi Naush

Thanks for this. Looks good to me!

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Best regards
David

On Fri, 26 Jun 2020 at 11:25, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> Coverity static analysis check was reporting print_ was not initialised
> before being used in process(). Add an explicit initialiser for print_
> to the constructor.
>
> Reported-by: Coverity CID=293456
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp
> index 1e2b6491..4028ba56 100644
> --- a/src/ipa/raspberrypi/controller/rpi/focus.cpp
> +++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp
> @@ -15,7 +15,7 @@ using namespace RPi;
>  #define NAME "rpi.focus"
>
>  Focus::Focus(Controller *controller)
> -       : Algorithm(controller)
> +       : Algorithm(controller), print_(false)
>  {
>  }
>
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel