[libcamera-devel] [PATCH 06/13] libcamera: ipu3: imgu: Do not cache index

Niklas Söderlund niklas.soderlund at ragnatech.se
Sat Jun 27 05:00:36 CEST 2020


The numerical index of the imgu is only used to create its name in
string form. There is no need to keep it around after that, remove it.

Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
---
 src/libcamera/pipeline/ipu3/imgu.cpp | 3 +--
 src/libcamera/pipeline/ipu3/imgu.h   | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp
index 26a95979d0c7735a..5d11539605f26303 100644
--- a/src/libcamera/pipeline/ipu3/imgu.cpp
+++ b/src/libcamera/pipeline/ipu3/imgu.cpp
@@ -37,8 +37,7 @@ int ImgUDevice::init(MediaDevice *media, unsigned int index)
 {
 	int ret;
 
-	index_ = index;
-	name_ = "ipu3-imgu " + std::to_string(index_);
+	name_ = "ipu3-imgu " + std::to_string(index);
 	media_ = media;
 
 	/*
diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h
index 9bb1b88e2ca8ea2d..ad5aabf134e2099d 100644
--- a/src/libcamera/pipeline/ipu3/imgu.h
+++ b/src/libcamera/pipeline/ipu3/imgu.h
@@ -69,7 +69,6 @@ public:
 		      bool enable);
 	int enableLinks(bool enable);
 
-	unsigned int index_;
 	std::string name_;
 	MediaDevice *media_;
 
-- 
2.27.0



More information about the libcamera-devel mailing list