[libcamera-devel] [PATCH 07/13] libcamera: ipu3: imgu: Mark things that are internal as private

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Sat, Jun 27, 2020 at 05:00:37AM +0200, Niklas Söderlund wrote:
> Mark all variables and functions that are only used internally as
> private.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/imgu.h | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h
> index ad5aabf134e2099d..b6b08b4fef2d3a9d 100644
> --- a/src/libcamera/pipeline/ipu3/imgu.h
> +++ b/src/libcamera/pipeline/ipu3/imgu.h
> @@ -24,11 +24,6 @@ struct StreamConfiguration;
>  class ImgUDevice
>  {
>  public:
> -	static constexpr unsigned int PAD_INPUT = 0;
> -	static constexpr unsigned int PAD_OUTPUT = 2;
> -	static constexpr unsigned int PAD_VF = 3;
> -	static constexpr unsigned int PAD_STAT = 4;
> -
>  	/* ImgU output descriptor: group data specific to an ImgU output. */
>  	struct ImgUOutput {
>  		V4L2VideoDevice *dev;
> @@ -64,20 +59,27 @@ public:
>  	int start();
>  	int stop();
>  
> -	int linkSetup(const std::string &source, unsigned int sourcePad,
> -		      const std::string &sink, unsigned int sinkPad,
> -		      bool enable);
>  	int enableLinks(bool enable);
>  
> -	std::string name_;
> -	MediaDevice *media_;
> -
>  	V4L2Subdevice *imgu_;
>  	V4L2VideoDevice *input_;
>  	ImgUOutput output_;
>  	ImgUOutput viewfinder_;
>  	ImgUOutput stat_;
>  	/* \todo Add param video device for 3A tuning */
> +
> +private:
> +	static constexpr unsigned int PAD_INPUT = 0;
> +	static constexpr unsigned int PAD_OUTPUT = 2;
> +	static constexpr unsigned int PAD_VF = 3;
> +	static constexpr unsigned int PAD_STAT = 4;
> +
> +	int linkSetup(const std::string &source, unsigned int sourcePad,
> +		      const std::string &sink, unsigned int sinkPad,
> +		      bool enable);
> +
> +	std::string name_;
> +	MediaDevice *media_;
>  };
>  
>  } /* namespace libcamera */

-- 
Regards,

Laurent Pinchart