[libcamera-devel] [PATCH v3 0/2] libcamera: geometry: Add isNull() function to Size class
Niklas Söderlund
niklas.soderlund at ragnatech.se
Sun Jun 28 21:09:18 CEST 2020
Hi,
This is mainly Laurent's work I have just collected the tags and added a
small patch on-top to make use of it in the IPU3 pipeline handler. I
know the name of the helper (isNull vs isZero vs isValid vs isEmpty) is
still debated but I did not wish to lose track of where in the CIO2 the
helper should be used disregarding its final name.
If I understand things correctly Laurent and myself prefer isNull()
while Jacopo and Kieran seems fine with isNull() but would prefer
isValid() and isZero() respectively. In other words the perfect bikeshed
is almost built :-)
Laurent Pinchart (1):
libcamera: geometry: Add isNull() function to Size class
Niklas Söderlund (1):
libcamera: ipu3: cio2: Use Size::isNull()
include/libcamera/geometry.h | 1 +
src/libcamera/geometry.cpp | 6 ++++++
src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-
test/geometry.cpp | 10 ++++++++++
4 files changed, 18 insertions(+), 1 deletion(-)
--
2.27.0
More information about the libcamera-devel
mailing list