[libcamera-devel] [PATCH v3 2/2] libcamera: ipu3: cio2: Use Size::isNull()

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Sun, Jun 28, 2020 at 09:09:20PM +0200, Niklas Söderlund wrote:
> Use the Size::isNull() helper instead of using local code.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp
> index 885e2ca0d9677364..aa1459fb3599283b 100644
> --- a/src/libcamera/pipeline/ipu3/cio2.cpp
> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp
> @@ -185,7 +185,7 @@ CIO2Device::generateConfiguration(Size size) const
>  	StreamConfiguration cfg;
>  
>  	/* If no desired size use the sensor resolution. */
> -	if (!size.width && !size.height)
> +	if (size.isNull())
>  		size = sensor_->resolution();
>  
>  	/* Query the sensor static information for closest match. */

-- 
Regards,

Laurent Pinchart