[libcamera-devel] [PATCH 1/3] libcamera: ipu3: Improve error on multiple raw streams request

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Jun 28 22:40:29 CEST 2020


Hi Jacopo,

Thank you for the patch.

On Sun, Jun 28, 2020 at 05:55:37PM +0200, Jacopo Mondi wrote:
> Improve the error message emitted when multiple raw streams are
> requested.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index f2aa0caede7f..ef57196c32da 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -341,8 +341,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,
>  		case StreamRole::StillCaptureRaw: {
>  			if (streams.find(&data->rawStream_) == streams.end()) {
>  				LOG(IPU3, Error)
> -					<< "No stream available for requested role "
> -					<< role;
> +					<< "Multiple raw streams are not supported";
>  				break;
>  			}
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list