[libcamera-devel] rkisp1: Fix spelling

[Andrej Shadura]

.

On Tue, 30 Jun 2020 at 16:22, Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Hi Andrej,
>
> On 30/06/2020 14:58, Andrej Shadura wrote:
> > From: IOhannes m zmölnig <umlaeute at debian.org>
>
> Is this correct? It looks corrupted in my e-mail.

It was supposed to be IOhannes m zmölnig. I guess UTF-8 has got
mangled into Latin-1.

> > Fix a typo in the word "unknown".
> >
> > Signed-off-by: Andrej Shadura <andrewsh at debian.org>
>
> We require a Signed-off-by: from the Author, which is marked as
> umlaeute at debian.org in the header here.
>
> Have you authored this patch ? Or are you forwarding on from someone else?

IOhannes and I are co-maintainers of libcamera in Debian. He wrote
this patch and I’m forwarding it for him. He didn’t leave a sign-off,
but since this patch is trivial and arguably non-copyrightable, I
understand this should not be a problem (I can "re-author" it myself
or so can you). In fact, I wrote the patch description in its
entirely, so in a way I wrote more of the patch than he did :)

> For the actual content of the patch:
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> > ---
> >  src/ipa/rkisp1/rkisp1.cpp                | 2 +-
> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> > index fbdc908..bfd76cf 100644
> > --- a/src/ipa/rkisp1/rkisp1.cpp
> > +++ b/src/ipa/rkisp1/rkisp1.cpp
> > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event)
> >               break;
> >       }
> >       default:
> > -             LOG(IPARkISP1, Error) << "Unkown event " << event.operation;
> > +             LOG(IPARkISP1, Error) << "Unknown event " << event.operation;
> >               break;
> >       }
> >  }
> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > index 3c01821..3c3f3f3 100644
> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame,
> >               metadataReady(frame, action.controls[0]);
> >               break;
> >       default:
> > -             LOG(RkISP1, Error) << "Unkown action " << action.operation;
> > +             LOG(RkISP1, Error) << "Unknown action " << action.operation;
> >               break;
> >       }
> >  }
> >
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel
> >
>
> --
> Regards
> --
> Kieran



-- 
Cheers,
  Andrej