[libcamera-devel] rkisp1: Fix spelling

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jun 30 17:02:44 CEST 2020


Hi Kieran,

On Tue, Jun 30, 2020 at 03:15:49PM +0100, Kieran Bingham wrote:
> On 30/06/2020 14:58, Andrej Shadura wrote:
> > From: IOhannes m zmölnig <umlaeute at debian.org>

I'd blame your mail client (or possibly server), it looked good on my
side before you replied :-)

> Is this correct? It looks corrupted in my e-mail.
> 
> > 
> > Fix a typo in the word "unknown".
> > 
> > Signed-off-by: Andrej Shadura <andrewsh at debian.org>
> 
> We require a Signed-off-by: from the Author, which is marked as
> umlaeute at debian.org in the header here.
> 
> Have you authored this patch ? Or are you forwarding on from someone else?
> 
> 
> For the actual content of the patch:
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > ---
> >  src/ipa/rkisp1/rkisp1.cpp                | 2 +-
> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> > index fbdc908..bfd76cf 100644
> > --- a/src/ipa/rkisp1/rkisp1.cpp
> > +++ b/src/ipa/rkisp1/rkisp1.cpp
> > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event)
> >  		break;
> >  	}
> >  	default:
> > -		LOG(IPARkISP1, Error) << "Unkown event " << event.operation;
> > +		LOG(IPARkISP1, Error) << "Unknown event " << event.operation;
> >  		break;
> >  	}
> >  }
> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > index 3c01821..3c3f3f3 100644
> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame,
> >  		metadataReady(frame, action.controls[0]);
> >  		break;
> >  	default:
> > -		LOG(RkISP1, Error) << "Unkown action " << action.operation;
> > +		LOG(RkISP1, Error) << "Unknown action " << action.operation;
> >  		break;
> >  	}
> >  }

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list