[libcamera-devel] [PATCH v3 27/27] gst: Document dependencies and quick usage

[Laurent Pinchart]

Hi Nicolas,

Thank you for the patch.

On Fri, Mar 06, 2020 at 03:30:07PM -0500, Nicolas Dufresne wrote:
> Le vendredi 06 mars 2020 à 15:26 -0500, Nicolas Dufresne a écrit :
> > From: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> > 
> > This is a quick startup guide allowing to build and use the GStreamer element
> > from the libcamera source tree.
> > 
> > Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> > ---
> >  README.rst | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/README.rst b/README.rst
> > index fa14113..a06e444 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -64,4 +64,23 @@ for qcam: [optional]
> >  for documentation: [optional]
> >  	python3-sphinx doxygen
> >  
> > +for gstreamer: [optional]
> > +	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
> > +
> > +Using GStreamer plugin
> > +~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +To use GStreamer plugin from source tree, set the following environment so that
> > +GStreamer can find it.
> > +
> > +  export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer
> > +
> > +The debugging tool `gst-launch-1.0` can be used to construct and pipeline and test
> > +it. The following pipeline will stream from the camera named "Camera 1" onto  the
> > +default video display element on your system.
> > +
> > +.. code::
> > +
> > +  gst-launch-1.0 libcamerasrc name="Camera 1" ! videoconvert ! autovideosink
> 
> Crap, the property is camera-name= (not name) :-(.

With this fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

We will then likely rework the documentation to move it to
Documentation.

> I'll let you review, maybe
> you could just fixup this one for me (if we don't need a v4).

There's another minor issues with a s/NULL/nullptr/, nothing that calls
for a v4. I can fix when applying, or make the fixes, collect the tags
and give me a branch I can pull. Up to you.

> > +
> >  .. section-end-getting-started

-- 
Regards,

Laurent Pinchart