[libcamera-devel] [PATCH v2 2/2] gst: Fix GLib detection

Nicolas Dufresne nicolas.dufresne at collabora.com
Sat Mar 7 20:34:49 CET 2020


Le samedi 07 mars 2020 à 21:16 +0200, Laurent Pinchart a écrit :
> Commit 17cccc68a88f ("Add GStreamer plugin and element skeleton") has
> gained a last minute fix for a clang compilation error with GLib prior
> to v2.63.0. The fix wasn't properly tested, and failed to check the GLib
> dependency correctly. This resulted in compilation of the GStreamer
> element to always be disabled.
> 
> Fix this by changing the GLib package name from 'glib' to 'glib-2.0'.
> 
> Fixes: 17cccc68a88f ("Add GStreamer plugin and element skeleton")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>

> ---
>  src/gstreamer/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build
> index 8759a12205fa..e119e472cb58 100644
> --- a/src/gstreamer/meson.build
> +++ b/src/gstreamer/meson.build
> @@ -13,7 +13,7 @@ libcamera_gst_cpp_args = [
>      '-DPACKAGE="@0@"'.format(meson.project_name()),
>  ]
>  
> -glib_dep = dependency('glib', required : get_option('gstreamer'))
> +glib_dep = dependency('glib-2.0', required : get_option('gstreamer'))
>  
>  gst_dep_version = '>=1.14.0'
>  gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_dep_version,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20200307/610130dc/attachment.sig>


More information about the libcamera-devel mailing list