[libcamera-devel] [PATCH] test: file-descriptor: Fix undefined O_TMPFILE compilation error

Niklas Söderlund niklas.soderlund at ragnatech.se
Sun Mar 8 17:42:51 CET 2020


Hi Laurent,

Thanks for your work.

On 2020-03-07 23:25:29 +0200, Laurent Pinchart wrote:
> O_TMPFILE is not defined by all libc implementations. libcamera has an
> internal definition in utils.h to work around this. Include utils.h in
> the test to fix the compilation error.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas at ragnatech.se>

> ---
>  test/file-descriptor.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/file-descriptor.cpp b/test/file-descriptor.cpp
> index 3e5e880093e7..e467f3a7145e 100644
> --- a/test/file-descriptor.cpp
> +++ b/test/file-descriptor.cpp
> @@ -14,6 +14,7 @@
>  #include <libcamera/file_descriptor.h>
>  
>  #include "test.h"
> +#include "utils.h"
>  
>  using namespace libcamera;
>  using namespace std;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list