[libcamera-devel] [PATCH v4 4/6] libcamera: meson: Make libatomic and libdl dependencies reusable

Niklas Söderlund niklas.soderlund at ragnatech.se
Sun Mar 8 18:32:28 CET 2020


Hi Laurent,

Thanks for your work.

On 2020-03-08 02:04:31 +0200, Laurent Pinchart wrote:
> libcamera.so links against libatomic and libdl, and handles those
> dependencies directly in the shared_object() call. More components
> within libcamera will need those dependencies, extract them to named
> variables to make them reusable.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/libcamera/meson.build | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 1b69bc0dee54..87fa09cde63d 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -58,6 +58,8 @@ includes = [
>  subdir('pipeline')
>  subdir('proxy')
>  
> +libatomic = cc.find_library('atomic', required : false)
> +libdl = cc.find_library('dl')
>  libudev = dependency('libudev', required : false)
>  
>  if libudev.found()
> @@ -93,8 +95,8 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],
>  libcamera_sources += version_cpp
>  
>  libcamera_deps = [
> -    cc.find_library('atomic', required: false),
> -    cc.find_library('dl'),
> +    libatomic,
> +    libdl,
>      libudev,
>      dependency('threads'),
>  ]
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list