[libcamera-devel] [PATCH v2 5/6] libcamera: controls: Update usage and description for existing controls

[Naushir Patuck]

Switch to using floats for constrast and saturation control to be more
in-line with end-user expectations.

Expand on the descrption for the brightness, contrast and saturation
controls.

Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
---
 src/libcamera/control_ids.yaml | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 9a33094a..3d1b058f 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -192,13 +192,20 @@ controls:
 
   - Brightness:
       type: int32_t
-      description: Specify a fixed brightness parameter
+      description: |
+        Specify a fixed brightness parameter. Positive values (up to 65535)
+        produce brighter images; negative values (up to -65536) produce darker
+        images and 0 leaves pixels unchanged.
 
   - Contrast:
-      type: int32_t
-      description: Specify a fixed contrast parameter
+      type: float
+      description:  |
+        Specify a fixed contrast parameter. Normal contrast is given by the
+        value 1.0; larger values produce images with more contrast.
 
   - Saturation:
-      type: int32_t
-      description: Specify a fixed saturation parameter
+      type: float
+      description:  |
+        Specify a fixed saturation parameter. Normal saturation is given by
+        the value 1.0; larger values produce more saturated colours.
 ...
-- 
2.17.1