[libcamera-devel] [PATCH v3 2/7] libcamera: properties: Define 'lens' properties

[Jacopo Mondi]

Hi Niklas,

On Tue, Feb 18, 2020 at 10:14:49PM +0100, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your work.
>
> On 2020-02-18 12:27:47 +0100, Jacopo Mondi wrote:
> > Define properties that describe the optical characteristics of the image
> > sensor.
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> > ---
> >  src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > index 2ffe4d803c0f..4746c3744594 100644
> > --- a/src/libcamera/property_ids.yaml
> > +++ b/src/libcamera/property_ids.yaml
> > @@ -563,4 +563,38 @@ controls:
> >          The range of supported ISO sensitivities, as documented by the
> >          ISO 12232:2006 standard
> >
> > +  - LensApertures:
> > +      type: float
> > +      compound: true
> > +      description: |
> > +        The available lens apertures, expressed as f numbers (the ratio between
> > +        the lens focal distance and the diameter of the pupil aperture).
> > +
> > +        If the camera module has a fixed aperture, the property transports a
> > +        single value.
> > +
> > +  - LensFocalLength:
>
> Should this be renamed LensFocalLengths to indicate ti can carry more
> then one focal length similar to LensApertures?
>

ack

> > +      type: float
> > +      compound: true
> > +      description: |
> > +        The available lens focal lengths, expressed in millimeters.
> > +
> > +        If the camera module supports multiple focal lengths this property
> > +        reports the focal lengths associated with each discrete step. For
> > +        camera modules with a single focal length, a single value should be
> > +        instead reported.
>
> s/value should be instead reported/value is reported/
>

Ack

> > +
> > +  - LensHyperfocalDistance:
>
> LensHyperfocalDistances to indicate it's a compound control ?
>
> > +      type: float
> > +      compound: true
> > +      description: |
> > +        The hyperfocal distance of the camera module. The property is
> > +        particularly meaningful for modules with a single focal length.
>
> Is not the hyperfocal distance calculated using among other things the
> focal length and lens apertures? Is there an relationship between the
> data reported by the three controls?
>

I'm not sure, but I won't document here dependencies between phyisical
properties.

Thanks
   j
> My optics are not what they where when I left school so many years ago,
> sorry if I'm confused.
>
> > +
> > +  - LensMinimumFocusDistance:
> > +      type: float
> > +      description: |
> > +        The shortest distance in millimeters at which an object could be brought
> > +        into sharp focus.
> > +
> >  ...
> > --
> > 2.25.0
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel
>
> --
> Regards,
> Niklas Söderlund