[libcamera-devel] [PATCH LIBCAMERA 4/4] tests: remove IPA_PROXY_PATH environment variable

[Kieran Bingham]

Hi Kaaira

On 17/03/2020 17:31, Kaaira Gupta wrote:
> The tests declare a hard-coded LIBCAMERA_IPA_PROXY_PATH	to allow tests

It seems like there's an odd 'tab' between LIBCAMERA_IPA_PROXY_PATH and
'to' there.


> to run from the tests-suite.
> 
> Now that the proxy path is determined at runtime, we can remove the
> redundant setting of LIBCAMERA_IPA_PROXY_PATH for tests.

Fantastic :-)

This also has (good) implications that stand-alone test applications
will now be able to use the proxy workers as well before being
installed, but I don't think we need to mention that explicitly here.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>



> 
> Signed-off-by: Kaaira Gupta <kgupta at es.iitr.ac.in>
> ---
>  test/libtest/test.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp
> index 6cd3fbe..fd9f3d7 100644
> --- a/test/libtest/test.cpp
> +++ b/test/libtest/test.cpp
> @@ -21,10 +21,6 @@ int Test::execute()
>  {
>  	int ret;
>  
> -	ret = setenv("LIBCAMERA_IPA_PROXY_PATH", "src/libcamera/proxy/worker", 1);
> -	if (ret)
> -		return errno;
> -
>  	ret = init();
>  	if (ret)
>  		return ret;
> 

-- 
Regards
--
Kieran