[libcamera-devel] [PATCH v2 6/6] libcamera: controls: Add controls to report back frame metadata

[Kieran Bingham]

Hi Naush,

On 09/03/2020 12:33, Naushir Patuck wrote:
> Add controls to report the current frame's exposure and gain, and an
> estimate of the current lux level from the AE algorithm.
> 
> Add controls to report the red and blue colour gains, and an estimate of
> the colour temperature from the AWB algorithm.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/libcamera/control_ids.yaml | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 3d1b058f..ee93975e 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -138,6 +138,22 @@ controls:
>  
>          \sa ManualExposure
>  
> +  - CurrentExposure:
> +      type: int32_t
> +      description: Report the exposure time in micro-seconds of this frame.
> +
> +        \sa CurrentAnalogueGain
> +
> +  - CurrentAnalogueGain:
> +      type: float
> +      description: Report the analogue gain parameter for the current frame.
> +
> +        \sa CurrentExposure
> +
> +  - CurrentLux:
> +      type: float
> +      description: Report an estimate of the current lux level.
> +
>    - AwbEnable:
>        type: bool
>        description: |
> @@ -190,6 +206,18 @@ controls:
>          in that order.
>        size: [2]
>  
> +  - CurrentWbGains:
> +      type: float
> +      description: |
> +        Report the current gain AWB gain values for the Red and Blue colour
> +        channels, in that order.
> +      size: [2]
> +
> +  - CurrentTemperature:
> +      type: float
> +      description:  |
> +        Report the current estimate of the colour temperature for this frame.

Do we need to explicitly define the scale/units of the temperature?
(Presumably people would assume kelvins, but perhaps people could
misinterpret this somehow if we're not explicit)

> +
>    - Brightness:
>        type: int32_t
>        description: |
> 

-- 
Regards
--
Kieran