[libcamera-devel] [PATCH v2 0/7] Add support for V4L2 array controls

[Jacopo Mondi]

Hi Laurent,
   thanks for the review and for v2

On Sat, Mar 21, 2020 at 02:36:33AM +0200, Laurent Pinchart wrote:
> Hello,
>
> This is the second version of Jacopo's "[PATCH 00/11] Adda support for
> V4L2 array control and strings". Support for string controls has since
> then been merged, so the series now focusses solely on V4L2 array
> controls.
>
> Compared to v1, a patch has been added to introduce a zero-copy set API
> for ControlValue (1/7). Subsequent patches have been adapted to use this
> new API, and review comments on v1 have been addressed. Please see
> individual patches for details.

You've heard my initial skepticism for such a potentially disruptive
API, but the final result is -so much- better I'm now sold.

Test looks much better as well, so please have my
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
for the series and feel free to push!

Thanks
   j

>
> The series is based on the latest master branch.
>
> Jacopo Mondi (6):
>   libcamera: v4l2_controls: Cache query control information
>   libcamera: v4l2_device: Support writing array U8 controls
>   libcamera: v4l2_device: Support reading U8 array controls
>   libcamera: v4l2_controls: Support U8 array controls
>   libcamera: v4l2_device: Enable enumeration of U8 controls
>   test: v4l2_videodevice: Test U8 array controls
>
> Laurent Pinchart (1):
>   libcamera: controls: Add zero-copy set API for ControlValue
>
>  include/libcamera/controls.h               |  4 ++
>  src/libcamera/control_serializer.cpp       | 61 ++----------------
>  src/libcamera/controls.cpp                 | 54 ++++++++++++----
>  src/libcamera/include/control_serializer.h |  3 -
>  src/libcamera/include/v4l2_device.h        |  1 +
>  src/libcamera/v4l2_controls.cpp            |  9 +++
>  src/libcamera/v4l2_device.cpp              | 75 +++++++++++++++++-----
>  test/v4l2_videodevice/controls.cpp         | 30 ++++++++-
>  8 files changed, 148 insertions(+), 89 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>