[libcamera-devel] [PATCH 09/21] qcam: main_window: Don't print message when saving a picture

Kieran Bingham kieran.bingham at ideasonboard.com
Mon Mar 23 16:42:40 CET 2020


On 23/03/2020 14:21, Laurent Pinchart wrote:
> When saving a picture, the application prints a message on cout. This
> isn't necessary and doesn't really help with debugging or diagnostics,
> remove it.

Oh ... it helped me while I was making it at least ;-)

But it probably isn't required indeed.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/qcam/main_window.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
> index 18aae07ffce7..7aaa73e9a709 100644
> --- a/src/qcam/main_window.cpp
> +++ b/src/qcam/main_window.cpp
> @@ -406,9 +406,6 @@ void MainWindow::saveImageAs()
>  
>  	QString filename = QFileDialog::getSaveFileName(this, "Save Image", defaultPath,
>  							"Image Files (*.png *.jpg *.jpeg)");
> -
> -	std::cout << "Save image to " << filename.toStdString() << std::endl;
> -
>  	if (filename.isEmpty())
>  		return;
>  
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list