[libcamera-devel] [PATCH v3 2/6] libcamera: properties: Define 'lens' properties

[Kieran Bingham]

Hi Jacopo,

On 09/03/2020 18:04, Jacopo Mondi wrote:
> Define properties that describe the optical characteristics of the image
> sensor.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> 
> ---
> v2 -> v3:
> - Pluralize names of properties which transport multiple values
> - Again 'size' vs 'compound' is hard to guess
> ---
>  src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index 4cecb5ad9ac3..80f9b1b3c264 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -563,4 +563,38 @@ controls:
>          The range of supported ISO sensitivities, as documented by the
>          ISO 12232:2006 standard
>  
> +  - LensApertures:
> +      type: float
> +      size: [16]

Why 16?

> +      description: |
> +        The available lens apertures, expressed as f numbers (the ratio between
> +        the lens focal distance and the diameter of the pupil aperture).
> +
> +        If the camera module has a fixed aperture, the property transports a
> +        single value.


And the others should all be set to 0?

> +
> +  - LensFocalLengths:
> +      type: float
> +      size: [16]
> +      description: |
> +        The available lens focal lengths, expressed in millimeters.
> +
> +        If the camera module supports multiple focal lengths this property
> +        reports the focal lengths associated with each discrete step. For
> +        camera modules with a single focal length, a single value should be
> +        instead reported.
> +
> +  - LensHyperfocalDistances:
> +      type: float
> +      size: [16]
> +      description: |
> +        The hyperfocal distance of the camera module. The property is
> +        particularly meaningful for modules with a single focal length.
> +
> +  - LensMinimumFocusDistance:
> +      type: float
> +      description: |
> +        The shortest distance in millimeters at which an object could be brought
> +        into sharp focus.
> +
>  ...
> 

-- 
Regards
--
Kieran