[libcamera-devel] [PATCH 7/7] libcamera: ipu3: Add support for a RAW still capture stream

[Niklas Söderlund]

Hi Laurent,

On 2020-03-27 00:46:34 +0200, Laurent Pinchart wrote:
> Hi Niklas,
> 
> On Thu, Mar 26, 2020 at 11:40:41PM +0100, Niklas Söderlund wrote:
> > On 2020-03-26 16:34:09 +0200, Laurent Pinchart wrote:
> > > > @@ -571,6 +617,9 @@ int PipelineHandlerIPU3::configure(Camera 
> > > > *camera, CameraConfiguration *c)
> > > >  		stream->active_ = true;
> > > >  		cfg.setStream(stream);
> > > 
> > > I think this is worth a comment to explain why.
> > > 
> > > 		/*
> > > 		 * The RAW still capture stream just copies buffers from the
> > > 		 * internal queue and doesn't need any specific configuration.
> > > 		 */
> > > 
> > > How about the interesting corner case of an application requesting the
> > > raw stream only ? :-) This can be fixed later, but please add a \todo.
> > 
> > It is already handled in this version, checkout 
> > IPU3CameraData::cio2BufferReady() :-) All special cases are handled raw 
> > and raw+other streams are handled. Even raw+other stream with request 
> > containing raw, video or raw+video buffers are ok.
> 
> But don't we still configure the ImgU in configure(), and start it in
> start() ?

Ahh yes I see your point. Yes we do configure it but we never use it if 
we only have a single raw stream. Point taken will add todo for this.

> 
> > $ cam -c2 -s role=stillraw -C
> > [0:04:33.966148860] [1345]  INFO Camera camera_manager.cpp:277 libcamera v0.0.0+1214-5c5a378c-dirty
> > [0:04:33.974212620] [1346]  INFO IPU3 ipu3.cpp:949 Registered Camera[0] "ov13858 2-0010 0" connected to CSI-2 receiver 0
> > [0:04:33.974519559] [1346]  INFO IPU3 ipu3.cpp:949 Registered Camera[1] "ov5670 4-0036 1" connected to CSI-2 receiver 1
> > Using camera ov5670 4-0036 1
> > [0:04:33.975128859] [1345]  INFO Camera camera.cpp:770 configuring streams: (0) 2592x1944-0x30314142
> > Capture until user interrupts by SIGINT
> > fps: 0.00 stream0 seq: 000001 bytesused: 6469632
> > fps: 31.25 stream0 seq: 000002 bytesused: 6469632
> > fps: 30.30 stream0 seq: 000003 bytesused: 6469632
> > fps: 32.26 stream0 seq: 000004 bytesused: 6469632
> > fps: 32.26 stream0 seq: 000005 bytesused: 6469632
> > fps: 29.41 stream0 seq: 000006 bytesused: 6469632
> > fps: 28.57 stream0 seq: 000007 bytesused: 6469632
> > fps: 30.30 stream0 seq: 000008 bytesused: 6469632
> > fps: 32.26 stream0 seq: 000009 bytesused: 6469632
> > fps: 30.30 stream0 seq: 000010 bytesused: 6469632
> > fps: 30.30 stream0 seq: 000011 bytesused: 6469632
> > fps: 31.25 stream0 seq: 000012 bytesused: 6469632
> > ^CExiting
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Regards,
Niklas Söderlund