[libcamera-devel] [PATCH v3 6/6] qcam: Check that camera can generate configuration from roles
Niklas Söderlund
niklas.soderlund at ragnatech.se
Fri May 1 04:34:32 CEST 2020
If the camera can not generate a configuration from the requested roles
it returns a nullptr which leads to a nullptr dereference. Fix this by
adding a check that the camera generated a configuration before trying
to access it.
Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
src/qcam/main_window.cpp | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
index 74427592ea47de28..b9348111dfa28914 100644
--- a/src/qcam/main_window.cpp
+++ b/src/qcam/main_window.cpp
@@ -296,6 +296,10 @@ int MainWindow::startCapture()
/* Configure the camera. */
config_ = camera_->generateConfiguration(roles);
+ if (!config_) {
+ qWarning() << "Failed to generate configuration from roles";
+ return -EINVAL;
+ }
StreamConfiguration &cfg = config_->at(0);
--
2.26.2
More information about the libcamera-devel
mailing list