[libcamera-devel] [PATCH 2/5] qcam: dng_writer: Name arguments to packScanline()

[Niklas Söderlund]

Hi Laurent,

Thanks for your work.

On 2020-05-03 01:57:01 +0300, Laurent Pinchart wrote:
> Name arguments to the FormatInfo::packScanline function pointer to make
> it easier to understand its usage when reading the function declaration.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/qcam/dng_writer.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp
> index b1984c6647dd..d5270323abd4 100644
> --- a/src/qcam/dng_writer.cpp
> +++ b/src/qcam/dng_writer.cpp
> @@ -23,7 +23,8 @@ enum CFAPatternColour : uint8_t {
>  struct FormatInfo {
>  	uint8_t bitsPerSample;
>  	CFAPatternColour pattern[4];
> -	void (*packScanline)(void *, const void *, unsigned int);
> +	void (*packScanline)(void *output, const void *input,
> +			     unsigned int width);
>  };
>  
>  void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund