[libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media properties
Hans Verkuil
hverkuil-cisco at xs4all.nl
Mon May 11 09:27:57 CEST 2020
On 09/05/2020 11:04, Jacopo Mondi wrote:
> Add a DT header file to contain definitions for standard media properties.
>
> The file is named after:
> Documentation/devicetree/bindings/media/video-interfaces.txt
> which contains the standard media properties definitions.
>
> Initially add three macros to define the supported 'orientation'
> property values.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>
> I currently don't have users in mainline for this, I understand this implies
> this is probably not going to be accepted. At the same time we don't have a
> common place for media-related definitions, which support properties defined in
> video-interfaces.txt
>
> I leave it here at the end of the series for discussions, but I'm fine dropping
> it from the series.
>
> Thanks
> j
>
> ---
> include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 0000000000000..404c697d6bd6e
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * include/dt-bindings/media/video-interfaces.h
> + *
> + * Copyright (C) 2020 Jacopo Mondi <jacopo at jmondi.org>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define FRONT_CAMERA <0>
> +#define BACK_CAMERA <1>
> +#define EXTERNAL_CAMERA <2>
Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ?
I'm skipping this patch for the PR.
Regards,
Hans
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
> --
> 2.26.1
>
More information about the libcamera-devel
mailing list