[libcamera-devel] [PATCH] ipa: Drop v4l2_controls.h from ipa_interface.h

Kieran Bingham kieran.bingham at ideasonboard.com
Tue May 12 09:48:13 CEST 2020


Hi Laurent,

On 12/05/2020 00:39, Laurent Pinchart wrote:
> The v4l2_controls.h header is internal, and isn't needed by
> ipa_interface.h. It originates from the days when V4L2 controls were
> handled through a different API. Drop it.
> 
> Fixes: 319d6ae8e3ad ("libcamera: controls: Merge ControlInfoMap and V4L2ControlInfoMap")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  include/ipa/ipa_interface.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h
> index a2d5e3dd1f51..dc9fc714d564 100644
> --- a/include/ipa/ipa_interface.h
> +++ b/include/ipa/ipa_interface.h
> @@ -123,8 +123,6 @@ struct ipa_context *ipaCreate();
>  #include <libcamera/geometry.h>
>  #include <libcamera/signal.h>
>  
> -#include "v4l2_controls.h"
> -
>  namespace libcamera {
>  
>  struct IPASettings {
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list