[libcamera-devel] [PATCH v2 1/4] test: ipc: unixsocket: Close open fds on error paths
Umang Jain
email at uajain.com
Fri May 15 14:42:52 CEST 2020
Pointed out by Coverity DefectId=279099
Signed-off-by: Umang Jain <email at uajain.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
test/ipc/unixsocket.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp
index f53042b..5348f35 100644
--- a/test/ipc/unixsocket.cpp
+++ b/test/ipc/unixsocket.cpp
@@ -145,6 +145,7 @@ private:
if (num < 0) {
cerr << "Read failed" << endl;
+ close(outfd);
stop(-EIO);
return;
} else if (!num)
@@ -152,6 +153,7 @@ private:
if (write(outfd, buf, num) < 0) {
cerr << "Write failed" << endl;
+ close(outfd);
stop(-EIO);
return;
}
--
2.26.2
More information about the libcamera-devel
mailing list