[libcamera-devel] [PATCH v2 0/3] raspberrypi: FPS control

[Nicolas Dufresne]

Le mercredi 13 mai 2020 à 10:11 +0100, Naushir Patuck a écrit :
> Hi,
> 
> This is the v2 patchset for framerate control on the Raspberry Pi platform.
> 
> There are quite substantial updates from the v1 patch:
> - Added min/max frame duration controls to libcamera.

The cover letter says FPS control, this patch adds frame duration
control. Did we chose frame duration simply because V4L2 works that
way? What do we want to standard on? How is sensor programmed in this
regard? What is the most natural configuration? An FPS fraction, or a
frame duration ?

> - Control vblanking for both min and max frame duration.
> - Moved GetVBlanking() into the CamHelper base class.
> - Updated tunings for the imx219, imx477 and ov5647 sensors to limit maximum exposure times.
> 
> Thanks,
> Naush
> 
> Naushir Patuck (3):
>   libcamera: controls: Add frame duration control
>   libcamera: raspberrypi: Add control of sensor vblanking
>   ipa: raspberrypi: config: Update shutter speeds for imx219/477 and
>     ov5647
> 
>  include/ipa/raspberrypi.h                     |  1 +
>  src/ipa/raspberrypi/cam_helper.cpp            | 38 ++++++++++++++-
>  src/ipa/raspberrypi/cam_helper.hpp            | 15 +++++-
>  src/ipa/raspberrypi/cam_helper_imx219.cpp     | 11 ++++-
>  src/ipa/raspberrypi/cam_helper_imx477.cpp     | 11 ++++-
>  src/ipa/raspberrypi/cam_helper_ov5647.cpp     | 11 ++++-
>  src/ipa/raspberrypi/data/imx219.json          | 15 +++++-
>  src/ipa/raspberrypi/data/imx477.json          | 15 +++++-
>  src/ipa/raspberrypi/data/ov5647.json          | 15 +++++-
>  src/ipa/raspberrypi/raspberrypi.cpp           | 48 ++++++++++++++++---
>  src/libcamera/control_ids.yaml                | 14 ++++++
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  2 +
>  12 files changed, 177 insertions(+), 19 deletions(-)
>