[libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM FourCCs with libcamera formats

[Kieran Bingham]

Hi Laurent,


<snip>

On 28/05/2020 12:11, Laurent Pinchart wrote:
> Hi Kieran,
>>>  static const QMap<libcamera::PixelFormat, QImage::Format> nativeFormats
>>>  {
>>>  #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)
>>> -	{ libcamera::PixelFormat{ DRM_FORMAT_ABGR8888 }, QImage::Format_RGBA8888 },
>>> +	{ libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },
>>>  #endif
>>> -	{ libcamera::PixelFormat{ DRM_FORMAT_ARGB8888 }, QImage::Format_RGB32 },
>>> +	{ libcamera::formats::ARGB8888, QImage::Format_RGB32 },
>>>  #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
>>> -	{ libcamera::PixelFormat{ DRM_FORMAT_BGR888 }, QImage::Format_BGR888 },
>>> +	{ libcamera::formats::BGR888, QImage::Format_BGR888 },
>>>  #endif
>>> -	{ libcamera::PixelFormat{ DRM_FORMAT_RGB888 }, QImage::Format_RGB888 },
>>> +	{ libcamera::formats::RGB888, QImage::Format_RGB888 },
>>
>> Excepting the format swap necessary on BGR888/RGB888 in regards to the
>> QImage formats, which has been identified after you created this patch:
> 
> I'll rebase this on top of the fix you've submitted, once you merge it.

Well in that case, try a git fetch now ;-)

> 
>> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>>
>>>  };
>>>  
>>>  ViewFinder::ViewFinder(QWidget *parent)
> 

-- 
Regards
--
Kieran