[libcamera-devel] [PATCH v4 01/37] utils: ipc: import mojo

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Nov 10 11:03:55 CET 2020


Hi Paul,

On 10/11/2020 00:22, Niklas Söderlund wrote:
> Hi Paul,
> 
> Thanks for your work.
> 
> On 2020-11-06 19:36:31 +0900, Paul Elder wrote:
>> Import mojo from the Chromium repository, so that we can use it for
>> generating code for the IPC mechanism. The commit from which this was
>> taken is:
>> a079161ec8c6907b883f9cb84fc8c4e7896cb1d0 "Add PPAPI constructs for
>> sending focus object to PdfAccessibilityTree"
>>
>> This tree has been pruned to remove directories that didn't have any
>> necessary code:
>> - mojo/* except for mojo/public
>>   - mojo core, docs, and misc files
>> - mojo/public/* except for mojo/public/{tools,LICENSE}
>>   - language bindings for IPC, tests, and some mojo internals
>> - mojo/public/tools/{fuzzers,chrome_ipc}
>> - mojo/public/tools/bindings/generators
>>   - code generation for other languages
>>
>> No files were modified.
>>
>> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
>> Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> This patch is _huge_ and there is no way I will review all files and 
> diff them against the mentioned upstream commit, so I trust your when 
> you say none of the files are modified,
> 
> Acked-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>


Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

How about we treat patches [1, 2, 3] as a mini-series to provide Mojo
support, and get those in "immediately" to prevent reposting large
patches which aren't expected to change or churn?

--
Kieran



>>
>> ---
>> No change in v4
>>
>> No change in v3
>>


<snippity>


>> -- 
>> 2.27.0
>>
>> _______________________________________________
>> libcamera-devel mailing list
>> libcamera-devel at lists.libcamera.org
>> https://lists.libcamera.org/listinfo/libcamera-devel
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list