[libcamera-devel] [PATCH v1 2/5] cam: Use libevent to implement event loop

[Kieran Bingham]

On 16/11/2020 14:52, Laurent Pinchart wrote:
> Hi Kieran,
>>>  
>>> +	struct event_base *event_;
>>>  	std::atomic<bool> exit_;
>>>  	int exitCode_;
>>
>> It might not have been introduced by this patch, but it seems to have
>> been highlighted during this rebuild. Could you check if this is a real
>> issue or a false positive please?
>>
>>
>> If you supply a patch to fix this issue, please add the following tag:
>>
>> Reported-by: Coverity CID=305971
>>
>> Alternatively, if you believe it's a false positive, let me know and
>> I'll close it.
> 
> I've noticed the report. The diagnostic is right, exitCode_ is not
> initialized in the constructor, but that's not an issue as it's
> initialized in all code paths that may potentially use it.

That's fine, I've closed this one.

Thanks
--
Kieran



> 
>> Hi,
>>
>> Please find the latest report on new defect(s) introduced to libcamera
>> found with Coverity Scan.
>>
>> 1 new defect(s) introduced to libcamera found with Coverity Scan.
>> 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the
>> recent build analyzed by Coverity Scan.
>>
>> New defect(s) Reported-by: Coverity Scan
>> Showing 1 of 1 defect(s)
>>
>>
>> ** CID 305971:  Uninitialized members  (UNINIT_CTOR)
>> /home/linuxembedded/iob/libcamera/libcamera-daily/src/cam/event_loop.cpp: 23
>> in EventLoop::EventLoop()()
>>

-- 
Regards
--
Kieran