[libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface: Remove all functions from IPAInterface

[paul.elder at ideasonboard.com]

Hi Jacopo,

On Tue, Nov 17, 2020 at 05:19:55PM +0100, Jacopo Mondi wrote:
> Hi Paul,
> 
> On Fri, Nov 06, 2020 at 07:36:48PM +0900, Paul Elder wrote:
> > Now that all the functions in the IPA interface are defined in the data
> > definition file and a specialized IPAInterface is generated per pipeline
> > handler, remove all the functions from the case IPAInterface.
> >
> > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> >
> 
> I wonder if all cleanups could be done at the end of the series after
> all pipelines/IPAs have been converted.

There's a circular dependency. The pipelines/IPAs depend on these
cleanups/preparations, and once these cleanups/preparations are in, the
old pipelines/IPAs won't work anymore. That's why 13 to 33 have to be
squashed...

> Anyway
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>


Thanks,

Paul

> > ---
> > No change in v4
> >
> > No change in v3
> >
> > No change in v2
> > ---
> >  include/libcamera/ipa/ipa_interface.h | 16 ----------------
> >  1 file changed, 16 deletions(-)
> >
> > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
> > index 48766b22..8d4264c3 100644
> > --- a/include/libcamera/ipa/ipa_interface.h
> > +++ b/include/libcamera/ipa/ipa_interface.h
> > @@ -46,22 +46,6 @@ class IPAInterface
> >  {
> >  public:
> >  	virtual ~IPAInterface() = default;
> > -
> > -	virtual int init(const IPASettings &settings) = 0;
> > -	virtual int start() = 0;
> > -	virtual void stop() = 0;
> > -
> > -	virtual void configure(const CameraSensorInfo &sensorInfo,
> > -			       const std::map<unsigned int, IPAStream> &streamConfig,
> > -			       const std::map<unsigned int, const ControlInfoMap &> &entityControls,
> > -			       const IPAOperationData &ipaConfig,
> > -			       IPAOperationData *result) = 0;
> > -
> > -	virtual void mapBuffers(const std::vector<IPABuffer> &buffers) = 0;
> > -	virtual void unmapBuffers(const std::vector<unsigned int> &ids) = 0;
> > -
> > -	virtual void processEvent(const IPAOperationData &data) = 0;
> > -	Signal<unsigned int, const IPAOperationData &> queueFrameAction;
> >  };
> >
> >  } /* namespace libcamera */
> > --
> > 2.27.0
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel