[libcamera-devel] [PATCH 1/2] src: ipa: raspberrypi: Add missing 'cloudly' AWB mode

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Nov 18 14:12:53 CET 2020


Hi David,

On 17/11/2020 09:32, David Plowman wrote:
> This had just been forgotten.

Perhaps:

"Support the 'cloudy' AWB mode which was left out when the AwbModeTable
was introduced."

But it doesn't warrant a resend, and doesn't really matter.


> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 4632d764..9853a343 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -477,6 +477,7 @@ static const std::map<int32_t, std::string> AwbModeTable = {
>  	{ controls::AwbFluorescent, "fluorescent" },
>  	{ controls::AwbIndoor, "indoor" },
>  	{ controls::AwbDaylight, "daylight" },
> +	{ controls::AwbCloudy, "cloudy" },
>  	{ controls::AwbCustom, "custom" },

Is there any particular sort ordering on this table?

>  };
>  
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list