[libcamera-devel] [PATCH 1/3] Early return if no cameras are found on the system.

[Kieran Bingham]

Hi Umang,

$SUBJECT is missing a "simple-cam:" prefix to match the others.

Was this patch already posted somewhere?

I don't seem to be able to find it, but I do half-recollect it ;-)
I just can't figure out where from.


On 19/11/2020 12:34, Umang Jain wrote:
> Failing to do so, the codepath will segfault while trying to acquire
> a non-existent camera.
> 
> Signed-off-by: Umang Jain <email at uajain.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  simple-cam.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/simple-cam.cpp b/simple-cam.cpp
> index 727bb6d..af9c8b1 100644
> --- a/simple-cam.cpp
> +++ b/simple-cam.cpp
> @@ -307,6 +307,13 @@ int main()
>  	for (std::unique_ptr<Request> &request : requests)
>  		camera->queueRequest(request.get());
>  
> +	if(!cm->cameras().size()) {
> +		std::cout << "No cameras were identified on the system."
> +			  << std::endl;
> +		cm->stop();
> +		return -1;

I think we should we return -ENODEV instead of -1 here. We already use
errno values (for example -ENOMEM is used).

--
Kieran


> +	}
> +
>  	/*
>  	 * --------------------------------------------------------------------
>  	 * Run an EventLoop
> 

-- 
Regards
--
Kieran