[libcamera-devel] [PATCH] libcamera: controls: Improve Control documentation grammar

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Fri, Nov 20, 2020 at 03:00:21PM +0000, Kieran Bingham wrote:
> A few grammatical errors remain in the Control class documentation.
> Fix them.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/controls.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp
> index aad461121651..c58ed3946f3b 100644
> --- a/src/libcamera/controls.cpp
> +++ b/src/libcamera/controls.cpp
> @@ -437,8 +437,8 @@ void ControlValue::reserve(ControlType type, bool isArray, std::size_t numElemen
>   * the control value. See for instance how the ControlList::get() method
>   * returns a value corresponding to the type of the requested control.
>   *
> - * While this class is the main mean to refer to a control, the control
> - * identifying information are stored in the non-template base ControlId class.
> + * While this class is the main means to refer to a control, the control
> + * identifying information is stored in the non-template base ControlId class.
>   * This allows code that operates on a set of controls of different types to
>   * reference those controls through a ControlId instead of a Control. For
>   * instance, the list of controls supported by a camera is exposed as ControlId

-- 
Regards,

Laurent Pinchart