[libcamera-devel] [PATCH v4 15/37] libcamera: IPAProxy: Remove stop() override

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Fri, Nov 06, 2020 at 07:36:45PM +0900, Paul Elder wrote:
> Since stop() is part of the IPA interface, and the IPA interface is now
> generated based on the data definition file per pipeline, this no longer
> needs to be overrided by the base IPAProxy. Remove it.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
> No change in v4
> 
> No change in v3
> 
> Changes in v2:
> - remove documentation
> ---
>  include/libcamera/internal/ipa_proxy.h |  2 --
>  src/libcamera/ipa_proxy.cpp            | 10 ----------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h
> index 49399f4e..59a5b841 100644
> --- a/include/libcamera/internal/ipa_proxy.h
> +++ b/include/libcamera/internal/ipa_proxy.h
> @@ -27,8 +27,6 @@ public:
>  
>  	std::string configurationFile(const std::string &file) const;
>  
> -	void stop() override = 0;
> -
>  protected:
>  	std::string resolvePath(const std::string &file) const;
>  
> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp
> index ff4d7fd1..23be24ad 100644
> --- a/src/libcamera/ipa_proxy.cpp
> +++ b/src/libcamera/ipa_proxy.cpp
> @@ -145,16 +145,6 @@ std::string IPAProxy::configurationFile(const std::string &name) const
>  	return std::string();
>  }
>  
> -/**
> - * \fn IPAProxy::stop()
> - * \brief Stop the IPA proxy
> - *
> - * This function stops the IPA and releases all the resources acquired by the
> - * proxy in start(). Calling stop() when the IPA proxy hasn't been started or
> - * has already been stopped is valid, the proxy shall treat this as a no-op and
> - * shall not forward the call to the IPA.
> - */
> -
>  /**
>   * \brief Find a valid full path for a proxy worker for a given executable name
>   * \param[in] file File name of proxy worker executable

-- 
Regards,

Laurent Pinchart