[libcamera-devel] [PATCH v4 19/37] libcamera: IPAInterface: make ipaCreate return IPAInterface

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Fri, Nov 06, 2020 at 07:36:49PM +0900, Paul Elder wrote:
> With the new IPC infrastructure, we no longer need the C interface as
> provided by struct ipa_context. Make ipaCreate return IPAinterface.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

I know it will all be squashed, but it would be easier to review the
patches if the changes were not so fine-grained. Squashing this with the
change that removes ipaCreate(), as well as the corresponding
documentation changes, would be more self-contained. As you'll need to
send a v5, *if* reworking this isn't too much work, it would be
appreciated.

> ---
> No change in v4
> 
> No change in v3
> 
> No change in v2
> ---
>  include/libcamera/ipa/ipa_interface.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
> index 8d4264c3..f6c40dc6 100644
> --- a/include/libcamera/ipa/ipa_interface.h
> +++ b/include/libcamera/ipa/ipa_interface.h
> @@ -50,4 +50,8 @@ public:
>  
>  } /* namespace libcamera */
>  
> +extern "C" {
> +libcamera::IPAInterface *ipaCreate();
> +}
> +
>  #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */

-- 
Regards,

Laurent Pinchart