[libcamera-devel] [PATCH v2 0/2] Digital gain control

[David Plowman]

Hi everyone

I was wondering if I could give this one its customary Monday morning nudge?

I notice that there was still some question last week over whether
metadata (that's not allowed as a control) should be able to signal
its maximum/minimum values. It doesn't really feel like an issue to me
- I just report what the pipeline did, I'm not really seeing a need to
report what the pipeline *might* have done! Other than that, it seems
we were largely agreed...?

Thanks again!
David

On Thu, 26 Nov 2020 at 14:50, David Plowman
<david.plowman at raspberrypi.com> wrote:
>
> Hi everyone
>
> Here (after much talking ourselves in circles!) is a second version of
> the digital gain control. I've taken Jacopo's text for the control
> description, and added a second patch that makes use of the control in
> the Raspberry Pi IPAs to add the digital gain to the metadata.
>
> This second patch doesn't really tell you very much. In our libcamera
> version of raspistill (still image capture app) there will be a line
> like this:
>
>     iso *= metadata.get<float>(controls::DigitalGain);
>
> and that's about it!
>
> Best regards
> David
>
> David Plowman (2):
>   libcamera: controls: Add DigitalGain control
>   src: ipa: raspberrypi: Add digital gain to libcamera metadata
>
>  src/ipa/raspberrypi/raspberrypi.cpp |  4 +++-
>  src/libcamera/control_ids.yaml      | 17 +++++++++++++++++
>  2 files changed, 20 insertions(+), 1 deletion(-)
>
> --
> 2.20.1
>