[libcamera-devel] [PATCH] utils: hooks: pre-push: Accept Acked-by in addition to Reviewed-by

[Kieran Bingham]

Hi Laurent,

On 02/10/2020 01:43, Laurent Pinchart wrote:
> Allow pushing commits that have no Reviewed-by tag but have at least one
> Acked-by tag.

Yup, in the past I've just skipped the checks using --no-verify - but I
think this is a better solution :-)

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  utils/hooks/pre-push | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push
> index 5dc8addabeb6..2417d379db4c 100755
> --- a/utils/hooks/pre-push
> +++ b/utils/hooks/pre-push
> @@ -57,10 +57,10 @@ do
>  			errors=$((errors+1))
>  		fi
>  
> -		# 3. A Reviewed-by is required.
> -		if ! echo "$msg" | grep -q '^Reviewed-by: '
> +		# 3. A Reviewed-by or Acked-by is required.
> +		if ! echo "$msg" | grep -q '^\(Reviewed\|Acked\)-by: '
>  		then
> -			echo >&2 "No Reviewed-by in commit $commit"
> +			echo >&2 "No Reviewed-by or Acked-by in commit $commit"
>  			errors=$((errors+1))
>  		fi
>  	done
> 

-- 
Regards
--
Kieran