[libcamera-devel] [PATCH v2 13/13] android: camera_device: Clear streams_ at stop time

[Kieran Bingham]

Hi Jacopo,

On 06/10/2020 15:44, Jacopo Mondi wrote:
> When the CameraDevice is stopped, we need to clear the vector
> of CameraStream instances to make sure they get deleted and all the
> resources they have acquired get released.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Sounds good to me too. I see any reconfiguration already clears down the
streams, so indeed this looks good.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/android/camera_device.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 58a9f44db219..8da70e817b46 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -517,6 +517,8 @@ int CameraDevice::open(const hw_module_t *hardwareModule)
>  
>  void CameraDevice::close()
>  {
> +	streams_.clear();
> +
>  	camera_->stop();
>  	camera_->release();
>  
> 

-- 
Regards
--
Kieran