[libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+

[Kieran Bingham]

Hi Tomi,

On 07/10/2020 10:22, Tomi Valkeinen wrote:
> I get the warnings related to psabi with:
> 
> gcc 9.3.0 "arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0"
> 
> Remove the check for gcc-9, so that -Wno-psabi is used on all gcc
> versions over 7.1.

It doesn't seem unreasonable to keep this disabled for now.

Should it be < 10 instead though?

We're not *yet* worried about abi stability anyway, but perhaps we'll
need to check through some of this when we do consider stabilising.

It might be that we end up requiring a greater minimum compiler or such
to prevent us hitting the changes that were affected. But for now ...

With some consideration of if <10 is more applicable or not, and
eitherway after that:

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at iki.fi>
> ---
>  meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index dd88eea..16f1c6f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -75,8 +75,7 @@ if cc.get_id() == 'gcc'
>      # passing on ARM platforms. This generates a large number of messages
>      # during compilation with gcc >=7.1 until gcc 9. Silence them.
>      if (host_machine.cpu_family() == 'arm' and
> -        cc.version().version_compare('>=7.1') and
> -        cc.version().version_compare('<9'))
> +        cc.version().version_compare('>=7.1'))
>          cpp_arguments += [
>              '-Wno-psabi',
>          ]
> 

-- 
Regards
--
Kieran