[libcamera-devel] [PATCH 3/4] cam: fix use of uninitialized field

[Kieran Bingham]

Hi Tomi,

On 07/10/2020 10:22, Tomi Valkeinen wrote:
> Initialize last_ to 0 to avoid uninitialized use.
> 

Indeed, I suspect we have more uninitialised class members that need
sorting too, we have quite a few reported by coverity. Some of course
aren't essential, but I almost prefer initialising everything ;-)

But this one is indeed an uninitialised access in Capture::requestComplete.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

I guess we could add a fixes tag, but it doesn't really matter ;-)
There's no backporting happening here ;-)

> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at iki.fi>
> ---
>  src/cam/capture.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp
> index 5510c00..995614a 100644
> --- a/src/cam/capture.cpp
> +++ b/src/cam/capture.cpp
> @@ -17,7 +17,7 @@ using namespace libcamera;
>  
>  Capture::Capture(std::shared_ptr<Camera> camera, CameraConfiguration *config,
>  		 EventLoop *loop)
> -	: camera_(camera), config_(config), writer_(nullptr), loop_(loop),
> +	: camera_(camera), config_(config), writer_(nullptr), last_(0), loop_(loop),
>  	  captureCount_(0), captureLimit_(0)
>  {
>  }
> 

-- 
Regards
--
Kieran