[libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing initialize of status_
Tomi Valkeinen
tomi.valkeinen at iki.fi
Wed Oct 7 13:07:41 CEST 2020
Many fields in status_ are not initialized, causing use of uninitialized
memory.
Drop the code that clears some of the individual fields, and instead
just memset the whole thing.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen at iki.fi>
---
src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp
index df4d364..9e75178 100644
--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp
+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp
@@ -148,14 +148,8 @@ Agc::Agc(Controller *controller)
exposure_mode_(nullptr), constraint_mode_(nullptr),
frame_count_(0), lock_count_(0)
{
+ memset(&status_, 0, sizeof(status_));
ev_ = status_.ev = 1.0;
- flicker_period_ = status_.flicker_period = 0.0;
- fixed_shutter_ = status_.fixed_shutter = 0;
- fixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;
- // set to zero initially, so we can tell it's not been calculated
- status_.total_exposure_value = 0.0;
- status_.target_exposure_value = 0.0;
- status_.locked = false;
output_status_ = status_;
}
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
More information about the libcamera-devel
mailing list