[libcamera-devel] [RFC 4/6] libcamera: pipeline_handler: Initialize properties_

[Kieran Bingham]

Hi Jacopo,

On 11/09/2020 17:20, Jacopo Mondi wrote:
> Initialize the CameraData::properties_ field with the list of
> libcamera defined properties.
> 

Maybe it will be clearer in the following patches, but what is the
purpose of this?

This doesn't initialise it with any specific default values - just sets
the properties are available. And perhaps not all properties will be
available on every pipeline ? Or have I missed something obvious...

This seems odd to me at the moment ;(

> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  include/libcamera/internal/pipeline_handler.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h
> index a4e1b529c461..e579da711b33 100644
> --- a/include/libcamera/internal/pipeline_handler.h
> +++ b/include/libcamera/internal/pipeline_handler.h
> @@ -17,6 +17,7 @@
>  
>  #include <libcamera/controls.h>
>  #include <libcamera/object.h>
> +#include <libcamera/property_ids.h>
>  #include <libcamera/stream.h>
>  
>  #include "libcamera/internal/ipa_proxy.h"
> @@ -37,7 +38,7 @@ class CameraData
>  {
>  public:
>  	explicit CameraData(PipelineHandler *pipe)
> -		: pipe_(pipe)
> +		: pipe_(pipe), properties_(properties::properties)
>  	{
>  	}
>  	virtual ~CameraData() {}
> 

-- 
Regards
--
Kieran