[libcamera-devel] [PATCH 3/3] android: CameraStream: Fix nitpick indentation for mutex_

Kieran Bingham kieran.bingham at ideasonboard.com
Thu Oct 15 21:33:15 CEST 2020


Hi Umang,

On 15/10/2020 18:14, Umang Jain wrote:
> Signed-off-by: Umang Jain <email at uajain.com>

I'd be tempted to put this at the start of the series, so you clean up
then build on top.

But it's not essential,

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/android/camera_stream.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
> index c55d90b..c2cb121 100644
> --- a/src/android/camera_stream.h
> +++ b/src/android/camera_stream.h
> @@ -141,7 +141,7 @@ private:
>  	 * The class has to be MoveConstructible as instances are stored in
>  	 * an std::vector in CameraDevice.
>  	 */
> -	 std::unique_ptr<std::mutex> mutex_;
> +	std::unique_ptr<std::mutex> mutex_;
>  	std::unique_ptr<PostProcessor> postProcessor_;
>  };
>  
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list