[libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \file block above namespace

[Umang Jain]

Hi Laurent,

Thank you for the patch.

On 10/20/20 5:33 AM, Laurent Pinchart wrote:
> Make the whole code base consistent by placing the doxygen \file block
> above the libcamera namespace opening. There's a single offender, and
> two locations in which a white line is missing.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
LGTM. I found src/libcamera/utils.cpp to be a bit-special but seems OK 
to me. It would help you can double check it too.
Reviewed-by: Umang Jain <email at uajain.com>
> ---
>   src/libcamera/byte_stream_buffer.cpp | 8 ++++----
>   src/libcamera/v4l2_pixelformat.cpp   | 1 +
>   src/libcamera/v4l2_videodevice.cpp   | 1 +
>   3 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp
> index df7029b02a7f..eb9003927266 100644
> --- a/src/libcamera/byte_stream_buffer.cpp
> +++ b/src/libcamera/byte_stream_buffer.cpp
> @@ -12,15 +12,15 @@
>   
>   #include "libcamera/internal/log.h"
>   
> -namespace libcamera {
> -
> -LOG_DEFINE_CATEGORY(Serialization);
> -
>   /**
>    * \file byte_stream_buffer.h
>    * \brief Managed memory container for serialized data
>    */
>   
> +namespace libcamera {
> +
> +LOG_DEFINE_CATEGORY(Serialization);
> +
>   /**
>    * \class ByteStreamBuffer
>    * \brief Wrap a memory buffer and provide sequential data read and write
> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp
> index 6b05909f56ae..03ab085c1231 100644
> --- a/src/libcamera/v4l2_pixelformat.cpp
> +++ b/src/libcamera/v4l2_pixelformat.cpp
> @@ -22,6 +22,7 @@
>    * \file v4l2_pixelformat.h
>    * \brief V4L2 Pixel Format
>    */
> +
>   namespace libcamera {
>   
>   LOG_DECLARE_CATEGORY(V4L2)
> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
> index 508522ef42bb..16162e1edba3 100644
> --- a/src/libcamera/v4l2_videodevice.cpp
> +++ b/src/libcamera/v4l2_videodevice.cpp
> @@ -32,6 +32,7 @@
>    * \file v4l2_videodevice.h
>    * \brief V4L2 Video Device
>    */
> +
>   namespace libcamera {
>   
>   LOG_DECLARE_CATEGORY(V4L2)