[libcamera-devel] [PATCH 2/8] v4l2: Omit extra semicolons

[Laurent Pinchart]

Hi Hiro-san,

Thank you for the patch.

On Tue, Oct 20, 2020 at 02:28:59PM +0900, Hirokazu Honda wrote:
> LOG_DECLARE_CATEGORY macro contains the semicolon. The end
> semicolon with the macro is unnecessary.
> 
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/v4l2/v4l2_camera.cpp       | 2 +-
>  src/v4l2/v4l2_camera_proxy.cpp | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp
> index 35d3bed..97825c7 100644
> --- a/src/v4l2/v4l2_camera.cpp
> +++ b/src/v4l2/v4l2_camera.cpp
> @@ -14,7 +14,7 @@
>  
>  using namespace libcamera;
>  
> -LOG_DECLARE_CATEGORY(V4L2Compat);
> +LOG_DECLARE_CATEGORY(V4L2Compat)
>  
>  V4L2Camera::V4L2Camera(std::shared_ptr<Camera> camera)
>  	: camera_(camera), isRunning_(false), bufferAllocator_(nullptr),
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index 8ff990f..7803d37 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -32,7 +32,7 @@
>  
>  using namespace libcamera;
>  
> -LOG_DECLARE_CATEGORY(V4L2Compat);
> +LOG_DECLARE_CATEGORY(V4L2Compat)
>  
>  V4L2CameraProxy::V4L2CameraProxy(unsigned int index,
>  				 std::shared_ptr<Camera> camera)

-- 
Regards,

Laurent Pinchart